Attention is currently required from: Edward O'Callaghan.

Patch set 1:Code-Review +1

View Change

1 comment:

• File internal.c:

  • Patch Set #1, Line 223:

    ret = get_params(cfg,
    			 &force_boardenable, &force_boardmismatch,
    			 &force_laptop, &not_a_laptop,
    			 &board_vendor, &board_model);
    	if (ret)
    		return ret;
    

    It would be nice to have this done in pre-init as well. To do so, one would need to add a pointer to an opaque struct. The definition of the opaque struct would be private for each programmer, so each programmer would define its own struct to store the values of programmer-specific cfg options. The end goal would be to separate command-line parameter parsing from actual programmer init.

    We can (and should) discuss this in a video call, e.g. dev meeting or the like.

    (Marking as unresolved only because we need to agree on where/when to discuss this further)

To view, visit change 71620. To unsubscribe, or for help writing mail filters, visit settings.