
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30995 ) Change subject: ichspi: Add Apollo Lake support ...................................................................... Patch Set 1: (4 comments) https://review.coreboot.org/#/c/30995/1/ich_descriptors.c File ich_descriptors.c: https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@244 PS1, Line 244: 7
This should be correct. But please check this value again. My documentation says something else. […] Ah, it's 17MHz for the read speed, 14MHz for others. It's just an informational string, should we make it "14 MHz / 17 MHz"?
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@348 PS1, Line 348: ME
On APL this is not the place for the ME/TXE image. […] I don't think it makes it too confusing? We could make a distinction by chipset, but is it worth the effort?
Naming it "ME/TXE" maybe? I'd say it should suffice to know that it is ME/TXE related. https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@452 PS1, Line 452: TXE
This is only the TXE ROM Bypass for pre production not the whole TXE That's right, though, does it matter that much here?
https://review.coreboot.org/#/c/30995/1/ichspi.c File ichspi.c: https://review.coreboot.org/#/c/30995/1/ichspi.c@1758 PS1, Line 1758: num_freg = 16
Is this BIOS_FREGx from APL Datasheet 3 (334819-001)? There are only BIOS_FREG0 ... […] You might have to scroll down, there is another set at 0xe0.
-- To view, visit https://review.coreboot.org/c/flashrom/+/30995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1c464b5b3d151e6d28d5db96495fe874a0a45718 Gerrit-Change-Number: 30995 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 24 Jan 2019 13:04:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src@posteo.de> Gerrit-MessageType: comment