Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk.
3 comments:
Commit Message:
Patch Set #2, Line 11: endian
endianness
Done
Patchset:
The C compiler can only inline what it can see, i.e. what is in header files. […]
I've mixed a little bit around with macros and inline functions. Now it should be fulfill the requirements.
The swap functions are static inline c, which gives type safety. the cpu_to_X and X_to_cpu functions have readable prototypes in the header and the implementation is streamlined with macros.
File hwaccess.h:
uint8_t swap8 (const uint8_t value);
uint16_t swap16(const uint16_t value);
uint32_t swap32(const uint32_t value);
uint64_t swap64(const uint64_t value);
How about making these `static inline`? I'm usually not concerned, but […]
Done
To view, visit change 62898. To unsubscribe, or for help writing mail filters, visit settings.