Attention is currently required from: Angel Pons, Nicholas Chin.

View Change

4 comments:

• File ch347t_spi.c:

  • Patch Set #5, Line 94: typedef uint32_t __le32;

    Why the typedefs?

    all the data structure transfed to ch347 should be little endian. create this typedef can remind me doing a cpu_to_le32 before any transfer.

  • Patch Set #5, Line 110: } __attribute__((packed));

    This doesn't seem to be portable.

    It's OK for gcc based compiler. Or we can create a portable marco such as '__packed' to replace all the "__attribute__((packed))" in the source code.

  • Patch Set #5, Line 169:

    if (n > CH347_MAX_DATA_WRITE)
    			n = CH347_MAX_DATA_WRITE;
    

    This doesn't seem to be a good idea...

    I can't find a better idea, could you please give me some advices?

  • Patch Set #5, Line 279: memset(&csctrl, 0, sizeof(csctrl));

    Why not use an initialiser? […]

    OK

To view, visit change 70529. To unsubscribe, or for help writing mail filters, visit settings.