Attention is currently required from: Anastasia Klimchuk.

Patch set 1:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 7: .

    nit: no trailing period in the commit summary

• File tests/flashrom.c:

  • Patch Set #1, Line 31: free(text);

    I'd define a helper macro to avoid repeating this pattern:

     #define assert_string_equal_with_free(text, expected)	\
     	do {						\
     		assert_string_equal(text, expected);	\
     		free(text);				\
     	while (0)

    Two things to note:

    • I've intentionally used a macro instead of a function. Because `assert_string_equal` is a macro that uses `__FILE__` and `__LINE__`, using a helper function would result in the wrong line number being printed.
    • The do-while construct in the macro is intentional: https://gcc.gnu.org/onlinedocs/cpp/Swallowing-the-Semicolon.html

To view, visit change 51243. To unsubscribe, or for help writing mail filters, visit settings.