Nico Huber merged this change.

View Change

fixup! Convert flashrom to git

Note the non-strict POSIX compatibility in getrevision.sh and a add missing full stop*.* ;)

Change-Id: Ia60186f783067ba084439a8ef701dc8f4c0072f0
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: https://review.coreboot.org/21828
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
---
M util/getrevision.sh
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/util/getrevision.sh b/util/getrevision.sh
index 0f97546..9dd4dbe 100755
--- a/util/getrevision.sh
+++ b/util/getrevision.sh
@@ -1,4 +1,5 @@
 #!/bin/sh
+# NB: Supposed to be POSIX compatible but at least the usage of 'local' is not.
 #
 # This file is part of the flashrom project.
 #
@@ -78,7 +79,7 @@
 	echo "$(git ls-remote --exit-code --get-url ${target%/*}) ${target#*/}"
 }
 
-# Returns a string indicating where others can get the current source code (excluding uncommitted changes)
+# Returns a string indicating where others can get the current source code (excluding uncommitted changes).
 # Takes one optional argument: the path to inspect
 scm_url() {
 	local url=

To view, visit change 21828. To unsubscribe, visit settings.