View Change
1 comment:
File lspcon_i2c_spi.c:
Patch Set #4, Line 270: int ret = lspcon_i2c_spi_disable_all_protection(fd);
Sorry thought I have replied this but somehow it's missing. […]
ACK, will follow up with improvement if there are more comments comes in
To view, visit change 39687. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I039e683252cfaf1ffef8694a3e8081b1b6b944f7
Gerrit-Change-Number: 39687
Gerrit-PatchSet: 7
Gerrit-Owner: Shiyu Sun <sshiyu@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Sam McNally <sammc@google.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 04:51:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally <sammc@google.com>
Comment-In-Reply-To: Shiyu Sun <sshiyu@google.com>
Gerrit-MessageType: comment