View Change

1 comment:

• File it85spi.c:

  • Patch Set #10, Line 240: struct it85spi_data *data = (struct it85spi_data *) flash->mst->spi.data;

    I strongly oppose to the use of casts to discard const qualifiers. […]

    Angel, nice to meet you!

    I am currently trying to understand spi_master.data, and why it is const (so we are on the same page on "re-think the situation thoroughly"). Original commit where spi_master.data was introduced does not have much info on why data should be const. Maybe only the pointer can be const, but the data can be modified.

To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.