Attention is currently required from: Subrata Banik, Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• File ichspi.c:

  • Patch Set #12, Line 163: #define HSFC_FCYCLE(cyc) ((cyc) << HSFC_FCYCLE_OFF)

    Isn't this equivalent to `HSFC_FCYCLE_MASK`?

    Apparently it look same as its used for bit shift
    HSFC_FCYCLE_MASK: to represent the FCYCLE bit shift between ICH and PCH.
    HSFC_FCYCLE: takes SPI operation as argument and generate the the FCYCLE value for the same.

    Do you have suggestion to unifies both in meaningful way ?

  • Patch Set #12, Line 166: 4K

    Is it always 4K?

    atleast on PCH chipsets I could see it's since SPT PCH and Nico has mentioned some history here https://review.coreboot.org/c/flashrom/+/62870/6..8//COMMIT_MSG#b10

To view, visit change 62868. To unsubscribe, or for help writing mail filters, visit settings.