Attention is currently required from: Victor Ding.
View Change
1 comment:
File Makefile:
Patch Set #3, Line 177: endif
There is nothing special.
Good to know.
I thought they had to be verified but I was unable to test them.
I understand that testing on exotic platforms is annoying. However, you (and everyone else) can use `util/manibuilder` to build-test flashrom on many different platforms, including DOS using DJGPP (DJ's GNU Programming Platform). The toolchain that DJGPP uses is rather unusual, and can catch subtle issues like the one CB:52473 fixed.
I'll create a patch to allow them build again DOS and libpayload.
CB:55889 for ENE, CB:55890 for MEC1308.
To view, visit change 44580. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I970afd8c1bd92c159c60e09f22e2f18c0433729d
Gerrit-Change-Number: 44580
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Ding <victording@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Victor Ding <victording@google.com>
Gerrit-Comment-Date: Mon, 28 Jun 2021 11:37:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Victor Ding <victording@google.com>
Gerrit-MessageType: comment