Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan.

Patch set 5:Code-Review +1

View Change

1 comment:

• Commit Message:

  • Patch Set #5, Line 7: Confine is_internal checks under a symbol

    This is already done in some of the earlier patches, `is_internal_programmer()` already exists in flashrom.c. May I suggest a different commit message to reflect what is happening in the latest version of this patch:

    flashrom.c: Pass is_internal as an argument to *_help_message functions

    Providing is_internal as an argument allows *_help_message to be pure functions without side-effects, and to do one job: printing a message.

To view, visit change 67475. To unsubscribe, or for help writing mail filters, visit settings.