Anastasia Klimchuk submitted this change.

View Change



3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved
flashchips: Splitting flashchips into separate files by vendor

To make the flashchips "database" easier to manage, split it by vendor
into several smaller files. This commit transfers the bulk of the data
to separate files and includes them from `flashchips.c`. Although this
is ugly (.c includes are usually frowned upon), it is a necessary evil
to make this commit reproducible.

Tested in two ways:

1) Output of `flashrom -L` has no diffs with/without the patch
compared with diff and cmp tools

2) flashrom binary has no diffs with/without the patch
compared with diff and cmp tools
Note for binary comparison documentation and manpages need to be
disabled (documentation is actually modified in the patch), also
version in meson.build set to "none" (otherwise git version counts
every commit).

Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b
Co-developed-by: Angel Pons <th3fanbus@gmail.com>
Co-developed-by: Anastasia Klimchuk <aklm@flashrom.org>
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/83307
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
---
M MAINTAINERS
M doc/contrib_howtos/how_to_add_new_chip.rst
M flashchips.c
A flashchips/amd.c
A flashchips/amic.c
A flashchips/atmel.c
A flashchips/boya_bohong.c
A flashchips/bright.c
A flashchips/catalyst.c
A flashchips/ene.c
A flashchips/eon.c
A flashchips/esi.c
A flashchips/esmt.c
A flashchips/fudan.c
A flashchips/fujitsu.c
A flashchips/gigadevice.c
A flashchips/hyundai.c
A flashchips/intel.c
A flashchips/issi.c
A flashchips/macronix.c
A flashchips/micron.c
A flashchips/micron_numonyx_st.c
A flashchips/mosel_vitelic.c
A flashchips/nantronics.c
A flashchips/pmc.c
A flashchips/puya.c
A flashchips/sanyo.c
A flashchips/sharp.c
A flashchips/spansion.c
A flashchips/sst.c
A flashchips/st.c
A flashchips/syncmos_mosel_vitelic.c
A flashchips/ti.c
A flashchips/winbond.c
A flashchips/xmc.c
A flashchips/xtx.c
A flashchips/zetta.c
37 files changed, 24,143 insertions(+), 23,458 deletions(-)


To view, visit change 83307. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b
Gerrit-Change-Number: 83307
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>