Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Nikolai Artemiev.

Patch set 7:Code-Review +1

View Change

5 comments:

• File hwaccess.h:

  • Patch Set #7, Line 31:

    nit: drop blank line

  • Patch Set #7, Line 38:

    nit: drop blank line

  • Patch Set #7, Line 69: uint##bits##_t name##bits (const uint##bits##_t value) { return value; }

    nit: indent macro body for clarity:

     #define ___return_same(name, bits) \
     	uint##bits##_t name##bits (const uint##bits##_t value) { return value; }

  • Patch Set #7, Line 79: uint##bits##_t name##bits (const uint##bits##_t value) { return swap##bits (value); }

    Ditto

• File hwaccess_endian_big.c:

  • Patch Set #7:

    Idea: if `__FLASHROM_BIG_ENDIAN__` / `__FLASHROM_LITTLE_ENDIAN__` won't be removed, maybe add some `_Static_assert()` in here? The idea is to mention the CPU native endian inside these endian-specific files, and an assertion would be more useful than a comment.

To view, visit change 62898. To unsubscribe, or for help writing mail filters, visit settings.