Attention is currently required from: Nikolai Artemiev, Joursoir.
View Change
2 comments:
Patchset:
File cli_classic.c:
Patch Set #1, Line 1103: if (set_wp_region && wp_region)
I am wondering whether this condition needed. Maybe we can just have one line
free(wp_region);
I remember some time ago Angel explained to me that it is legit to call `free(pointer)` even if the pointer is null.
Angel, Nikolai, what do you think?
To view, visit change 64351. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe
Gerrit-Change-Number: 64351
Gerrit-PatchSet: 1
Gerrit-Owner: Joursoir <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Attention: Joursoir <chat@joursoir.net>
Gerrit-Comment-Date: Sun, 15 May 2022 23:49:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment