Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Patch set 2:Code-Review -1
View Change
1 comment:
File tests/lifecycle.c:
Patch Set #2, Line 336: W25Q128.V
So, this should be expected to fail, but happens to work because the chip […]
Thank you so much for finding the problem! I missed the elephant in the room, forgot about caching IDs :( I mark this as -1 to fix the problem. I believe probing in tests is a good idea, so I will continue working.
To view, visit change 59742. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I32d8e972d99b52c2b18f688aa6aeae75dd170f72
Gerrit-Change-Number: 59742
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Mon, 17 Jan 2022 06:16:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment