Nico Huber posted comments on this change.
Patch set 2:
(5 comments)
Patch Set #2, Line 398: ich_generation == CHIPSET_C620_SERIES_LEWISBURG) {
Please don't align the indendation with the body.
Patch Set #2, Line 1557: (((ICH_BRRA(frap) >> i) & 1) << 0);
Overflow for i >= 8 (have a fix in progress somewhere).
Patch Set #2, Line 1600: /* From 5 on we have GPR registers and start from 0 again. */
Oh, here's the comment ;)
Patch Set #2, Line 1703: num_freg = 12; /* 12 MMIO regs, but 16 regions in FD spec */
Depending on what the regular PCH returns for the register addresses,
12 might not hurt there either. I'm not sure any more why I set it
to 10, maybe based on some observation rather than the datasheet...
in the end, we only dump the registers anyway.
Patch Set #2, Line 1704: 6; /* FIXME: should be 5? */
num_pr = 6 seemed wrong for both Sunrise Point and Lewisburg, but maybe I a
6 including the GPR0 register, sorry should have added a comment...
To view, visit change 20922. To unsubscribe, visit settings.