Attention is currently required from: Angel Pons, Martin L Roth, Martin Roth, Nikolai Artemiev, Peter Marheine, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim.

View Change

8 comments:

• File flashchips.c:

  • Patch Set #8, Line 6590: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD

    Datasheet has BP4, so this should be `SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD`

    Done

  • Patch Set #8, Line 6591: SPI_DISABLE_BLOCKPROTECT

    SPI_DISABLE_BLOCKPROTECT_BP4_SRWD

    Done

  • Patch Set #8, Line 6594: {1600, 2000}

    Slight correction : from datasheet it's 1.65~2. […]

    Done

  • Patch Set #8, Line 6599: .tb = {STATUS1, 6, RW},

    In such cases you should add a comment: […]

    Done

  • Patch Set #8, Line 6646: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD

    SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD

    Done

  • Patch Set #8, Line 6647: SPI_DISABLE_BLOCKPROTECT

    SPI_DISABLE_BLOCKPROTECT_BP4_SRWD

    Done

  • Patch Set #8, Line 6650: {1600, 2000},

    1.65~2. […]

    Done

  • Patch Set #8, Line 6655: .tb = {STATUS1, 6, RW},

    Also as above, needs a comment: […]

    Done

To view, visit change 58025. To unsubscribe, or for help writing mail filters, visit settings.