Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

2 comments:

• File tests/chip.c:

  • Patch Set #1, Line 42: printf("Unlock chip called\n");

    If you're emulating a chip, I'd also mock and verify locking to increase test coverage

    I added chip state which counts how many times unlock was called, and then read/write/erase check that unlock has been called. This is all added for fake chip test.

  • Patch Set #1, Line 57: char *param_dup = strdup("");

    Hmmm, I guess the `memmove` inside that function changes the haystack. If so... […]

    Yes, from my memory it is memmove. I remember spending a while on this when I was writing the very first test, memmove did segfault because it was trying to modify read-only memory. Eventually I added strdup to workaround that.

To view, visit change 56501. To unsubscribe, or for help writing mail filters, visit settings.