Attention is currently required from: Anastasia Klimchuk, Brian Norris, Thomas Heijligen.

4 comments:

Commit Message:
- Patch Set #7, Line 10: )
  you can also add the link to archive (keep the title) https://mail.coreboot. […]
  Done
File tests/udelay.c:
- Patch Set #7, Line 47: default_delay(100);
  I thought for a moment we can afford a long delay test, for usec = 100001, but I don't know would it […]
  I think it's most useful to be testing the short delay case, since it's easy to understand the situations in which it should sleep and we depend on the OS for ensuring a sleep is long enough.
  My goal here was to have some confidence that timer-polling waits won't terminate early, and in that context I don't think it's very useful to exercise a long wait.
File udelay.c:
- Patch Set #7, Line 33:
```
#ifdef _POSIX_MONOTONIC_CLOCK
static clockid_t clock_id = CLOCK_MONOTONIC;
#else
static clockid_t clock_id = CLOCK_REALTIME;
#endif
```
  This is only used inside `clock_usec_delay` now, can it be locally defined inside the function? It w […]
  Done
- Patch Set #7, Line 62: inline
  For my education, why the function is inline only for this case and not the above?
  That's how it was before; no reason as far as I'm concerned. I've removed the inline.

To view, visit change 81545. To unsubscribe, or for help writing mail filters, visit settings.