Patch Set 2:

Just a warning, I had two dediprog SF100s with the same USB serial number which was what led me to the more convoluted id approach. I'm not sure how widespread this issue is.

Hmmm, you are right. Now that you mentioned it, I remember that they
pick random numbers out of a pool or something like that.

So the question is, how useful is this option?

Hi All

Thanks for the feedback -- I had not signed in to gerrit, so I didn't realize I had replies. I'll address it ASAP.

For quick replies, yes, the problem is still there if there are two identical serials. That's evil on the HW side (for starters).

In our usage model we have more than 1 dediprogs connected to the same machine. Since we have a pool of machines, we can always move one of the offending dediprogs to another host to avoid the serial# conflict. While this is not a solution for everyone, at least it is a solution--we can't fix the serial# conflict.

For someone that keeps having this problem, zeroing on other parameters might help (eg: USB tree path); that one is impractical for us, but might be for others.

View Change

To view, visit change 37406. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9cdfbce6cf941c16bf7b7364aa4166b91369e661
Gerrit-Change-Number: 37406
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Inaky Perez-Gonzalez
Gerrit-CC: Ryan O'Leary <ryanoleary@google.com>
Gerrit-Comment-Date: Sun, 19 Jan 2020 21:40:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment