Attention is currently required from: Edward O'Callaghan.
Patch set 3:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #3:
Unfortunately not as the call sites do not have access to the prog but rather the inner flashctx. […]
Good idea with the video chat to get all onto the same page!
I'm also not happy with the name of the variable, but it's not a deal breaker.
To view, visit change 70603. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I93dfe09fe877acd32c4f22665921544ccd9323f6
Gerrit-Change-Number: 70603
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Wed, 01 Mar 2023 09:51:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: comment