View Change

1 comment:

• File dediprog.c:

  • Patch Set #2, Line 1099: serial_number = extract_programmer_param("serial");

    I do agree on the leakage but...does it matter? Meaning if this is a one shot execution tool and once done all resources are freed by the OS, it's done--or am I wrong and there is a library usage of this I am not aware of where resource allocation would accumulate into a leakage?

    There is a library version of flashrom.

    
    Re id vs serial, this could be used to work around when identical USB serials are in the system (comment somewhere else in the thread), so this check could be an AND (id == SOMETHING and serial_number == SOMETHINGELSE). I'll rework a wee bit.

    I thought the IDs are unique, aren't they?

To view, visit change 37406. To unsubscribe, or for help writing mail filters, visit settings.