Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #1, Line 26:

    /* Remove the #define below if you don't want SPI flash chip emulation. */
    #define EMULATE_SPI_CHIP 1
    

    What I was wondering, is if EMULATE_SPI_CHIP is undefined then some chunks of code won't be included at all (chunks that are wrapped with #if EMULATE_SPI_CHIP). Is this a valid/useful case to keep? This option does not exist anymore after CB:55265 (those chunks of code are always included), but if it is useless then of course no point to keep it.

    The guards were added in commit f68aa8aca0a7e2852269f1b85b16535a3fb7cd14 (predates Gerrit), but I don't know what for. Currently, they're just noise, which is why I made CB:55265 to get rid of them.

To view, visit change 54748. To unsubscribe, or for help writing mail filters, visit settings.