Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Patch set 5:Code-Review -1
2 comments:
Commit Message:
Patch Set #2, Line 19: BUG=b:181803212
I'd like to know what the bug is?
Patchset:
It seems this is trying to fix problems that don't exist yet? Neither
is it decided if we'd like to mock different architectures in the
tests nor does the build system (the meson part) seem to support
more than x86/linux at the moment. Preprocessor guards should be
added only if really necessary. The x86 guards in programmers in
some comment are more a bug than a feature. Such things should be
handled by the build system, not in C code. Also, this header
file is included via -include compiler argument, if it were wrong
to include it, the build system should simply skip this argument,
no need to clutter the code.
To view, visit change 55741. To unsubscribe, or for help writing mail filters, visit settings.