Anastasia Klimchuk submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Nikolai Artemiev: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved
cli_classic: fix memory leak

If parameter --wp-region is used and wp_region is allocated,
free the last one at the exit of the application.

Found-by: scan-build, clang v13.0.1
Signed-off-by: Alexander Goncharov <chat@joursoir.net>
Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe
Reviewed-on: https://review.coreboot.org/c/flashrom/+/64351
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Nikolai Artemiev <nartemiev@google.com>
---
M cli_classic.c
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/cli_classic.c b/cli_classic.c
index 9543009..83ac538 100644
--- a/cli_classic.c
+++ b/cli_classic.c
@@ -1100,6 +1100,7 @@
free(referencefile);
free(layoutfile);
free(pparam);
+ free(wp_region);
/* clean up global variables */
free((char *)chip_to_probe); /* Silence! Freeing is not modifying contents. */
chip_to_probe = NULL;

To view, visit change 64351. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8520e302e9d63ed1215c5d9beb90a93fb52a91fe
Gerrit-Change-Number: 64351
Gerrit-PatchSet: 3
Gerrit-Owner: Joursoir <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged