Attention is currently required from: Arthur Heymans, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File ich_descriptors.c:

  • Patch Set #1, Line 945: if (content->ISL <= 139)

    AFAIK Eagle Stream is the only existing platform with the Emmitsburg PCH, and the BKC images I have for it show 80 straps. That's why I thought it was weird that we're using `<=` everywhere instead of `==`, although perhaps the person who originally wrote this code noticed some earlier chipsets did have overlapping ISL values, or they just didn't have access to enough docs/resources to know for sure.

    Not hard to figure out who that was, thanks to Git. IIRC, the original idea
    was to return a best-effort result rather than bailing out on unexpected
    values. That's all. It's not hard to change that to a strict return UNKNOWN
    as there is only one caller that would have to be adapted (at most). The
    "peculiar" warning before the last return on each branch provides the exact
    expected value.

    The code was written roughly ten years after the first descriptors showed
    up. With little real-world data at hand. So it's quite possible that some
    of the `<=` catch valid cases.

To view, visit change 57635. To unsubscribe, or for help writing mail filters, visit settings.