Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk.
4 comments:
Patchset:
Added the relevant datasheet to the commit message. […]
Done
Added
Done
File chipset_enable.c:
{0x8086, 0x7a90, B_S, NT, "Intel", "R680E", enable_flash_pch600},
{0x8086, 0x7a91, B_S, NT, "Intel", "Q670E", enable_flash_pch600},
{0x8086, 0x7a92, B_S, NT, "Intel", "H610E", enable_flash_pch600}
Thanks for ref to the doc! I found one https://cdrdv2-public.intel.com/743835/743835-004.pdf
I found all the device IDs there, but except of first 3 (0x7a90, 0x7a91, 0x7a92). But the doc says "volume 1 of 2", maybe they are in the volume 2?
It's fine to add from a doc which is not fully public, if you have such doc. If you can check that IDs still exist (since you mentioned in the other one that 0x7a8a was cancelled and later reused).
File util/ich_descriptors_tool/ich_descriptors_tool.c:
Patch Set #3, Line 142: "\t- \"600\" or \"alder\" for Intel's 600 series chipsets.\n"
Oh sorry, I said it in a confusing way! No, you don't need to add the output of the tool to commit message.
I meant to add something like this in commit message:
Updated ich_descriptors_tool to handle chipset name raptor, run the tool, output is correct as expected
The tool has its own build file, and can be run separately, so I wanted to mention in commit message that you did it and it works.
To view, visit change 83854. To unsubscribe, or for help writing mail filters, visit settings.