Attention is currently required from: Anastasia Klimchuk, Angel Pons, WereCatf.
Patch set 6:Code-Review +1
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
View Change
2 comments:
Commit Message:
Patch Set #6, Line 10: https://datasheet.lcsc.com/szlcsc/1908281813_PUYA-P25Q21H-SSH-IT_C414061.pdf
I cannot access this _part_ of the site from Switzerland / Russia.
Error Code: Access Denied
I used datasheet from this site (https://semic-boutique.com/wp-content/uploads/2016/05/P25Q21H-SSH-IT.pdf) to review the patch
File flashchips.c:
Patch Set #6, Line 14141: 256
The document that I used says: "3*512-Byte Security Registers With OTP Lock".
Is it the same in the one from lcsc.com?
To view, visit change 58134. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Idd43145c72607837cb7afa1b007e68eb8e63ebd9
Gerrit-Change-Number: 58134
Gerrit-PatchSet: 6
Gerrit-Owner: WereCatf <werecatf@outlook.com>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: WereCatf <werecatf@outlook.com>
Gerrit-Comment-Date: Sun, 29 Oct 2023 19:13:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment