Attention is currently required from: Jonathon Hall.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: commit 3b8b93e
Jonathon, Thank you for preparing this patch. […]
I commented on CB:66659 about the biggest problems I saw. If you want to get rid of the `programmer_param` global variable, CB:67094 is a great starting point, as it constrains the `programmer_param` global variable to the scope of the `programmer_init()` function. One would only need to plumb the variable through several function calls.
To view, visit change 67619. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie13bdcf63c23d912dc9b774ae279f1ae5883e287
Gerrit-Change-Number: 67619
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Comment-Date: Wed, 14 Sep 2022 10:47:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-MessageType: comment