Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Sam McNally.
View Change
1 comment:
Patchset:
Patch Set #2:
Also to add here: I actually have never seen the condition being called `if (last_addr < start_addr […]
Yes that condition wouldn't be called, because iirc the erase addresses are extend d to match the block boundaries. So ideally there should nothing be left once the above loop at line 309 finishes.
also I'm not sure if understand the double eraser invocation correctly, is it that a block is getting erased twice?
To view, visit change 77747. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28
Gerrit-Change-Number: 77747
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Sam McNally <sammc@google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Thu, 14 Sep 2023 12:48:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment