Attention is currently required from: Thomas Heijligen, Peter Marheine.
1 comment:
File Makefile:
Patch Set #3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
mark_unsupported only works as expected if CONFIG_INTERNAL is explicitly set.
It works fine, it's just hard to understand what it does. Traditionally,
we only complain about something unsupported if the user requested it
explicitly. If they didn't, mark_unsupported sets it to `no` silently.
The default later in this file isn't applied then.
CONFIG_INTERNAL is defaulted to yes further down the file, so it looks like the internal programmer can still be built as long as it's not explicitly enabled even with this change. I'm guessing nobody noticed that this conflicted with the MTD support because this disablement didn't work, with the end result that this mark_unsupported is now incorrect because internal is meant to work on other platforms when MTD is available.
No idea what you are talking about. The internal programmer is not meant
to work on other platforms, it only happened to work since the MTD intro-
duction and when using Meson. I just checked some ARM builds using `make`
and `internal` is disabled automatically as it should be. Given that there
were build errors with Meson, it's obvious: Build tests with the Makefile
would have failed too. We can change that behavior of course, as I depicted
earlier. I think we should just do that. If it builds for MIPSEL, it should
build for other architectures too. So we only have to treat x86 specially.
To view, visit change 61300. To unsubscribe, or for help writing mail filters, visit settings.