David Hendricks posted comments on this change.

View Change

Patch set 8:

I finally had a chance to address most of your comments from PS2, but there are a couple items outstanding (man page update, region and file names in layout).

(10 comments)

• File flashrom.8.tmpl:

  • Patch Set #8, Line 51: [(\fB\-l\fR <file>|\fB\-\-ifd\fR) [\fB\-i\fR <image>[:<file>]]] \

    Need to explain the updated syntax below.

• File flashrom.c:

  • Patch Set #2, Line 1308:

    		if (flash->chip->printlock)
    			flash->chip->printlock(flash);
    

    remove

    Done

  • Patch Set #2, Line 1342: (intmax_t)image_stat.s

    removed this line

  • Patch Set #2, Line 1353: out:

    IMHO, not having an empty line here was intentional.

    Done

  • Patch Set #2, Line 1392: if (fflush(image)) {

    If we make it the standard, the declaration should probably move

    Done: https://review.coreboot.org/#/c/21367/

  • Patch Set #2, Line 1404: if (S_ISREG(image_stat.st_mode)) {

    Now that we pass the flashctx, the size argument is redundant.

    Done.

  • Patch Set #2, Line 1407: ret = 1;

    ahem

    removed.

  • Patch Set #2, Line 1427:

    *const ? to match the other "variables"

    Done

  • Patch Set #2, Line 1444: if (!layout->entries[i].included)

    double blank line?

    Done

• File layout.h:

  • Patch Set #8, Line 46: char *file;

    Still need to address comments in PS2

To view, visit change 19342. To unsubscribe, visit settings.