Attention is currently required from: Mike Banon, Victor Ding, Matt DeVillier, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Anastasia Klimchuk, Iru Cai, Alexandru Gagniuc.
View Change
1 comment:
Patchset:
Patch Set #2:
I don't know any HP EliteBook having an ENE LPC programmer. I don't have a Folio 9480m now. […]
It's not known if the code worked on any device when merged. Actually, the
opposite, there was a flaw in the hook-up that made sure it wouldn't. It's
also not known if the code is device specific and what firmware, if any,
is expected on the EC.
I'd say it's best to get it through a proper review if anybody finds a use
case for it. Same story for the follow-up commit.
I don't advice to run this code on any device unless there is a way to
recover.
To view, visit change 56475. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b
Gerrit-Change-Number: 56475
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Ding <victording@google.com>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc@intel.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Iru Cai <mytbk920423@gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Iru Cai <mytbk920423@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Mike Banon <mikebdp2@gmail.com>
Gerrit-Attention: Victor Ding <victording@google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Iru Cai <mytbk920423@gmail.com>
Gerrit-Attention: Alexandru Gagniuc <alexandrux.gagniuc@intel.com>
Gerrit-Attention: Iru Cai <mytbk920423@gmail.com>
Gerrit-Comment-Date: Mon, 20 Sep 2021 20:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de>
Comment-In-Reply-To: Iru Cai <mytbk920423@gmail.com>
Gerrit-MessageType: comment