Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Subrata Banik.
View Change
1 comment:
File ichspi.c:
Patch Set #10, Line 1854: *region_write_access = mmio_readw(ich_spibar + ICH_REG_BIOS_BM_WAP);
Done
For your reference, the output would like
```
0x118: 0x00c2 (BIOS_BM_RAP)
0x11a: 0x0042 (BIOS_BM_WAP)
```
If it is the default value
https://edc.intel.com/content/www/de/de/design/publications/14th-generation-core-processors-soc-i-o-registers/bios-master-read-access-permissions-bios-bm-rap-offset-118/
https://edc.intel.com/content/www/de/de/design/publications/14th-generation-core-processors-soc-i-o-registers/bios-master-write-access-permissions-bios-bm-wap-offset-11c/
To view, visit change 81357. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1e06e7b3d470423a6014e623826d9234fdebfbf9
Gerrit-Change-Number: 81357
Gerrit-PatchSet: 12
Gerrit-Owner: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jamie Ryu <jamie.m.ryu@intel.com>
Gerrit-CC: Tyler Wang <tyler.wang@quanta.corp-partner.google.com>
Gerrit-Attention: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Thu, 02 May 2024 12:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen@google.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment