Attention is currently required from: Anastasia Klimchuk, Dmitry Zhadinets.

View Change

3 comments:

• File cli_classic.c:

  • Patch Set #3, Line 1216: if (ret == 1) {

    I mark this unresolved, because otherwise it is not shown in the latest diffs :( […]

    I agree that it's worth having this branch, even if we know that the library currently never returns it.

• File include/libflashrom.h:

  • Patch Set #4, Line 312: const char **all_matched_names,

    I initially tried p. […]

    The tricky part is that you end up needing a three-star pointer. A sample that tripped me up initially but I can confirm does work:

    ```
    const char *strings[] = {
        "foo",
        "bar",
    };

    int fetch_strings(const char ***sa) {
        int out = sizeof(strings) / sizeof(*strings);
        const char **outp = calloc(sizeof(strings) / sizeof(*strings), sizeof(const char*));
        for (int i = 0; i < out; i++) {
            outp[i] = strings[i];
        }
        *sa = outp;
        return out;
    }
    ```

  • Patch Set #4, Line 313: unsigned int *all_matched_count,

    That's an interesting idea! I also like to have one less parameter. […]

    Yeah, I think changing the meaning of the return value is fine since this also changes the entire function signature.

To view, visit change 87341. To unsubscribe, or for help writing mail filters, visit settings.