Patch Set 3: Code-Review+2

(3 comments)

I'm ok with the change, just the reasoning seems completely
wrong. It also deserves a comment above the includes that
we keep the order because we expect broken header files.

Yeah, your comment prompted me to look into this further and the commit message seems misleading.

I can go either way with this patch... On one hand, it's obsolete with newer versions of Linux. On the other hand, flashrom often runs on older systems.

I modified the commit message to be more accurate, at least, and added a comment in linux_spi.c about the reason for the ordering. I think we have some extra includes in there, but figure we should eventually run include-what-you-use or something to clean that all up at once.

View Change

1 comment:

To view, visit change 35830. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieab60f59bc63aca0dc4867f31699dab4167da05b
Gerrit-Change-Number: 35830
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 16 Oct 2019 01:53:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment