Patch Set 3: Code-Review+2
(3 comments)
I'm ok with the change, just the reasoning seems completely
wrong. It also deserves a comment above the includes that
we keep the order because we expect broken header files.
Yeah, your comment prompted me to look into this further and the commit message seems misleading.
I can go either way with this patch... On one hand, it's obsolete with newer versions of Linux. On the other hand, flashrom often runs on older systems.
I modified the commit message to be more accurate, at least, and added a comment in linux_spi.c about the reason for the ordering. I think we have some extra includes in there, but figure we should eventually run include-what-you-use or something to clean that all up at once.
1 comment:
Patch Set #3, Line 7: missing
This looks more like a workaround for broken kernel header files […]
Indeed, it's a bug in Linux that was fixed in 4.14:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/uapi/linux/spi/spidev.h?h=v5.4-rc3&id=a2b4a79b88b24c49d98d45a06a014ffd22ada1a4
To view, visit change 35830. To unsubscribe, or for help writing mail filters, visit settings.