Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.

View Change

2 comments:

• File tests/init_shutdown.c:

  • Patch Set #4, Line 214: int num_bytes = 0;

    Wow thank you for the whole code! I only removed
    `const char *data = NULL;`
    it seemed unused.

    Well spotted, it was indeed unused. I decided to use an array of structs halfway through and didn't realize that `data` was no longer needed.

• File tests/init_shutdown.c:

  • Patch Set #6, Line 237: return strlen(entry.data);

    Hmmm, now that I take a look at this again:

    • Shouldn't we honor the `size` and `len` parameters?
    • `strcpy()` also copies the null terminator, so the returned value should be `strlen(entry.data) + 1`.

To view, visit change 56413. To unsubscribe, or for help writing mail filters, visit settings.