View Change
1 comment:
File util/shell.nix:
Patch Set #3, Line 3: stdenv
The problem here is that /bin/sh can be anything.
Exactly.
So they decided using bash.
That's fine. But by telling so, they encourage script authors to write bash
scripts. And then they'll have a hard time when they want to work with an OS
that doesn't have /bin/bash.
To view, visit change 58012. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9757b952f4b034e98c2b4b70fbede52d8efb9d50
Gerrit-Change-Number: 58012
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Comment-Date: Tue, 12 Oct 2021 22:19:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment