Attention is currently required from: Alexander Goncharov, Fabrice Fontaine, Thomas Heijligen.
Patch set 2:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #1:
We're not using meson.build to compile flashrom in buildroot but indeed it seems all good.
Just to confirm that I'm correctly understanding the motivation for this, you don't need the internal programmer but it gets turned on by default even though it fails to build on sh4. Marking it as depending on raw memory access causes it to be default-disabled (on sh4), fixing the build.
To view, visit change 78930. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7610f5f7cc5b114ffa90d5752155acc8b6b7c9f7
Gerrit-Change-Number: 78930
Gerrit-PatchSet: 2
Gerrit-Owner: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alexander Goncharov <chat@joursoir.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Sun, 26 Nov 2023 22:22:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Alexander Goncharov <chat@joursoir.net>
Gerrit-MessageType: comment