Attention is currently required from: Felix Singer.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #7, Line 872: write_cmd = true;

    (Also not nice to change the style that the original author choose, IMO.)

    Why should the bool type be a problem for the author but not a change to the variable name? It might be not wanted by the author? Maybe the author doesn't like it?

    I try to balance between noise in the Git history, the state of the code,
    review resources, diversity, and how people might perceive what happens to
    their code. Changing the type alone is mostly noise to me. Changing the
    identifiers would make the code more readable, IMO, enough to alter the
    balance. It's all subjective of course.

    
    This is an open source project and not anyones personal project.

    It's a project made by people. Please don't ignore that they have
    feelings about it.

    Changing the same lines over and over again also unnecessarily drains review resources.

    How much time did it take to write these two comments? I guess you wasted more of your time with writing these comments than with actually reviewing this patch.

    Much less than it took me to review the whole series.

To view, visit change 66892. To unsubscribe, or for help writing mail filters, visit settings.