Patch Set 6: Code-Review-1

I would not want to see this merged, so as to not encourage in-circuit flashing on boards which are not designed for that due to the potential risks involved.

Angel, thank you very much for your wise detailed reply. Although I still intend to maintain this patch (since it turned out to be useful at least for this TL-WR841ND v9 and haven't damaged its' hardware), now I understand why it's not a good idea to merge it - may be more dangerous than a "dangerous" word implies ;)

View Change

To view, visit change 31830. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If47476793721a0061fd65bc6d1f98d48b03dc6c1
Gerrit-Change-Number: 31830
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Mike Banon <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Sun, 29 Dec 2019 17:49:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment