Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Subrata Banik.

View Change

11 comments:

• Commit Message:

  • Patch Set #10, Line 28:

    Is MTL a Meteor Lake and ADL Alder Point?

    Is it possible to test the chipsets that used to be after Meteor in the enum, and now they are before?

• File ichspi.c:

  • Patch Set #10, Line 1853: mmio_readw

    Why it is `readw` (reads into uint16_t) here, but `readl` below (reads into uint32_t)?
    You declare `region_read_access` and `region_write_access` as uint32_t actually

  • Patch Set #10, Line 1854: *region_write_access = mmio_readw(ich_spibar + ICH_REG_BIOS_BM_WAP);

    Maybe you can also add some debugging prints in this branch too

  • Patch Set #10, Line 1876: inline

    I don't think this needs to be inline?

  • Patch Set #10, Line 1877:

    if (ich_generation >= CHIPSET_METEOR_LAKE)
    		return 16;
    	return 8;
    

    maybe make it one line
    `return (ich_generation >= CHIPSET_METEOR_LAKE) ? 16 : 8;`

  • Patch Set #10, Line 2109: case CHIPSET_METEOR_LAKE:

    Let's re-order Meteor Lake here too

  • Patch Set #10, Line 2149: case CHIPSET_METEOR_LAKE:

    and here

  • Patch Set #10, Line 2211: case CHIPSET_METEOR_LAKE:

    and here

  • Patch Set #10, Line 2229:

    you can leave the word "registers", so that it is "... and region access registers"

  • Patch Set #10, Line 2291: case CHIPSET_METEOR_LAKE:

    and here

  • Patch Set #10, Line 2331: case CHIPSET_METEOR_LAKE:

    and here

To view, visit change 81357. To unsubscribe, or for help writing mail filters, visit settings.