Attention is currently required from: Nico Huber, David Hendricks, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons.
View Change
1 comment:
File hwaccess.h:
Patch Set #8, Line 104: #define be_to_cpu8 cpu_to_be8
Why do we need two macros to be the same? Why this can't be just one macro (any of these).
read_from(be, 8) expands into the call to be_to_cpu8, but why it can't call cpu_to_be8, they are the same anyway?
I am sure there is an answer, it is just me unable to understand from looking at the code.
To view, visit change 31016. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idde177acf8bc5f94cd046b6539dc31532c98e452
Gerrit-Change-Number: 31016
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Mon, 06 Sep 2021 04:40:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment