Edward O'Callaghan has uploaded this change for review.

View Change

jedec.c: Use JEDEC_ define from spi.h over magic

Change-Id: Id0c98ee900e37c26dc06f96a9950713f332240fd
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
---
M jedec.c
1 file changed, 12 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/72632/1
diff --git a/jedec.c b/jedec.c
index e13053f..7507415 100644
--- a/jedec.c
+++ b/jedec.c
@@ -132,7 +132,7 @@
/* Issue JEDEC Product ID Entry command */
chip_writeb(flash, 0xAA, bios + (0x5555 & mask));
chip_writeb(flash, 0x55, bios + (0x2AAA & mask));
- chip_writeb(flash, 0x90, bios + (0x5555 & mask));
+ chip_writeb(flash, JEDEC_REMS, bios + (0x5555 & mask));

/* Read product ID */
// FIXME: Continuation loop, second byte is at word 0x100/byte 0x200
@@ -216,7 +216,7 @@
chip_writeb(flash, 0x55, bios + ((shifted ? 0x5555 : 0x2AAA) & mask));
if (probe_timing_enter)
programmer_delay(flash, 10);
- chip_writeb(flash, 0x90, bios + ((shifted ? 0x2AAA : 0x5555) & mask));
+ chip_writeb(flash, JEDEC_REMS, bios + ((shifted ? 0x2AAA : 0x5555) & mask));
if (probe_timing_enter)
programmer_delay(flash, probe_timing_enter);


To view, visit change 72632. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id0c98ee900e37c26dc06f96a9950713f332240fd
Gerrit-Change-Number: 72632
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-MessageType: newchange