Attention is currently required from: Nikolai Artemiev, Peter Marheine, Thomas Heijligen.
4 comments:
File flashrom.c:
Can this be a macro in flash.h ? (I mean number 5)
File include/flash.h:
Patch Set #5, Line 325: TEST_ERASE_INJECTOR
Maybe remove this value? I know some existing tests are using it, but they can be adjusted. Right now it looks confusing, especially for new people who might try write a unit test: which value to use? TEST_ERASE_INJECTOR or TEST_ERASE_INJECTOR_1?
File tests/erase_func_algo.c:
Patch Set #5, Line 198: block_erase_chip, block_erase_chip, block_erase_chip, block_erase_chip, block_erase_chip
What if
you create 5 functions, block_erase_chip_1, ... , block_erase_chip_5
each of them will call `block_erase_chip` with one extra argument: a value from test injector enum on of TEST_ERASE_INJECTOR_X ?
and then you can populate `struct erase_invoke` in full, currently you only fill in 2 members out of 3
Maybe it can even be written in a macro-loop, but I am equally fine with 5 functions written in code.
File tests/meson.build:
Patch Set #5, Line 127: '-DFLASHROM_TEST',
Just to test , have you built with this option undefined?
Also I am thinking, maybe live without it? :) There are a bunch of #ifs already in the code
To view, visit change 82251. To unsubscribe, or for help writing mail filters, visit settings.