Attention is currently required from: Nico Huber, Miklós Márton, Thomas Heijligen.

Patch set 2:Code-Review +2

View Change

1 comment:

• File Makefile:

  • Patch Set #2, Line 217: DIR

    That's the broken part, btw. In theory the flashrom-stable Makefile should be working.

    Well the actual problematic line was in this one:
    https://review.coreboot.org/c/flashrom/+/75234/2/Makefile#b226

    The $(if NI854_X86_LIBRARY_PATH, -L${NI854_X86_LIBRARY_PATH}) expression appended an extra -L which caused linker failure. I personally doubt that NI will ever release a 64 bit NI-845x or change the installation path, but if they ever will it is easily going to be possible to use the modified installation path with the CONFIG_NI845X_LIBRARY_PATH.

To view, visit change 75234. To unsubscribe, or for help writing mail filters, visit settings.