David Hendricks posted comments on this change.

View Change

Patch set 1:Code-Review -1

Mostly looks good, just a few minor things.

(6 comments)

• Commit Message:

  • Patch Set #1, Line 9: spi_write_command

    spi_write_cmd

  • Patch Set #1, Line 10: erase

    block erase, since it doesn't apply to chip erase functions

  • Patch Set #1, Line 12: spi_write_command

    spi_write_cmd

• File spi25.c:

  • Patch Set #1, Line 326: spi_write_status

    spi_poll_status?

  • Patch Set #1, Line 377: JEDEC_WREN

    Hmmm, what do we do about chips that only use EWSR? I know this patch is only intended to replace the old functions, but maybe in a follow-up we can add some logic to check the feature bits to see which enable opcode we should use.

  • Patch Set #1, Line 383:

    Check if out_len < 1?

To view, visit change 22019. To unsubscribe, visit settings.