David Hendricks posted comments on this change.
Patch set 1:
Mostly looks good, just a few minor things.
Patch Set #1, Line 326:
Patch Set #1, Line 377:
Hmmm, what do we do about chips that only use EWSR? I know this patch is only intended to replace the old functions, but maybe in a follow-up we can add some logic to check the feature bits to see which enable opcode we should use.
Check if out_len < 1?
To view, visit change 22019. To unsubscribe, visit settings.