Attention is currently required from: Thomas Heijligen.
View Change
1 comment:
Commit Message:
Patch Set #4, Line 13: warning_level=2 means -Wall and -Wextra as it is set in
Needs update. This is now in the next patch.
This is actually not needed in any patch, I discovered that warning_level=2 already sets -Wall and -Wextra.
I still wanted to mention in commit message, so that it is clear why -Wall and -Wextra and not needed in the patch. So I added info in commit message.
I tried to re-write it a bit, so that it is more clear.
To view, visit change 58561. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id401bfd642dc3c13d85bd9a2dba56ada38714c25
Gerrit-Change-Number: 58561
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Tue, 26 Apr 2022 05:47:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment