Attention is currently required from: Peter Stuge, Name of user not set #1004601.
View Change
1 comment:
File serial.c:
Patch Set #4, Line 78: #if !IS_DARWIN
why guard the higher boudrates additionally for darwin? When looking at https://opensource.apple.com/source/xnu/xnu-792.2.4/bsd/sys/termios.h.auto.html those macros are not defined. so they should not be present in the list.
To view, visit change 70571. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3e6b88d2b4c2a130b16456752681fd9f807bf6f0
Gerrit-Change-Number: 70571
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Stuge <peter@stuge.se>
Gerrit-Reviewer: Name of user not set #1004601
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Peter Stuge <peter@stuge.se>
Gerrit-Attention: Name of user not set #1004601
Gerrit-Comment-Date: Thu, 15 Dec 2022 10:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment