Attention is currently required from: Aarya, Alexander Goncharov, Sam McNally.
View Change
1 comment:
Patchset:
Patch Set #2:
This is my attempt to fix the double invocation of every eraser, what do you think about it? I am no […]
Also to add here: I actually have never seen the condition being called `if (last_addr < start_addr + block_len)`
When I say "never" I mean that I tries all test cases from next patch CB:67535 and also ran with dummy `flashrom -p dummy:emulate=W25Q128FV -E` and I commented out the "full chip" erasers for this chip, so that algo need to go into a loop and not erase whole chip at once.
To view, visit change 77747. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I92351eba0fd29114ce98b4a839358e92d176af28
Gerrit-Change-Number: 77747
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Alexander Goncharov <chat@joursoir.net>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Sam McNally <sammc@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Sam McNally <sammc@google.com>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Alexander Goncharov <chat@joursoir.net>
Gerrit-Comment-Date: Thu, 14 Sep 2023 12:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment